Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix possible crashes at shutdown #2681

Merged
merged 2 commits into from
Dec 14, 2021
Merged

[BUG] Fix possible crashes at shutdown #2681

merged 2 commits into from
Dec 14, 2021

Conversation

random-zebra
Copy link

theuni and others added 2 commits December 13, 2021 14:20
@theuni @random-zebra
fix possible shutdown assertion with -reindex-shutdown
ed34832 
Credit @eklitzke for reproducing.
@TheBlueMatt @random-zebra
Fix fast-shutdown hang on ThreadImport+GenesisWait
0360cad 
If the user somehow manages to get into ShutdownRequested before
ThreadImport gets to ActivateBestChain() we may hang waiting on
condvar_GenesisWait forever. A simple wait_for and
ShutdownRequested resolves this case.
@random-zebra random-zebra added this to the 6.0.0 milestone Dec 13, 2021
@random-zebra random-zebra self-assigned this Dec 13, 2021
furszy
furszy approved these changes Dec 13, 2021
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0360cad

Fuzzbawls
Fuzzbawls approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0360cad

@random-zebra random-zebra merged commit 4645a54 into PIVX-Project:master Dec 14, 2021
@Fuzzbawls Fuzzbawls modified the milestones: 6.0.0, 5.5.0 Sep 11, 2022
JSKitty added a commit to ZENZO-Ecosystem/ZENZO-Core that referenced this pull request Jul 1, 2023
@JSKitty
Partial PIVX-Project#2681
bf05ccc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@furszy furszy furszy approved these changes

Assignees

@random-zebra random-zebra

Labels
Upstream
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@random-zebra @furszy @Fuzzbawls @theuni @TheBlueMatt